Migrate from notebooks #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
===========================================
- Coverage 100.00% 6.17% -93.83%
===========================================
Files 2 9 +7
Lines 4 178 +174
===========================================
+ Hits 4 11 +7
- Misses 0 167 +167
☔ View full report in Codecov by Sentry. |
This uses directly PublishedToJavascript when the function `core_published_to_js` is found This is because from next Pluto version `publish_to_js` will be deprecated. This commit also fixes the way automatic counters are computed in order to support logs In logs the :extra_items key is not added to IO This will help closing #5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves away from the package code being defined inside a single notebook and splits it into multiple files
It also changes the default way to server the plotly library. It now tries to save the bundled library locally on a generic path (obtained with BaseDirs.jl) and copy a copy of the bundled library file inside the pluto front-end folder so that it can be loaded simply with a relative path on the notebook.
If this fails, it reverts back to loading from URL.
This should fix #2 and avoid having a common window Plotly variable
The minimum julia version has been updated to 1.9
The way to extract the unique id for showing reliably multiple plots inside a same cell has been made more robust, in view of compatibility with logs from #5